chore: Update online store docstrings #3066
Conversation
felixwang9817
force-pushed
the
online_store
branch
from
dd3e934 to
3954587
Compare
| An online store defines the interface that Feast uses to interact with the the storage system | ||
| that handles online features. |
There was a problem hiding this comment.
| An online store defines the interface that Feast uses to interact with the the storage system | |
| that handles online features. | |
| The interface that Feast uses to interact with the the storage system | |
| that handles online features. |
There was a problem hiding this comment.
fixed, good catch
There was a problem hiding this comment.
also you have duplicate the
Codecov Report
@@ Coverage Diff @@
## master #3066 +/- ##
==========================================
+ Coverage 67.20% 75.87% +8.67%
==========================================
Files 168 203 +35
Lines 15011 16983 +1972
==========================================
+ Hits 10088 12886 +2798
+ Misses 4923 4097 -826
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
felixwang9817
force-pushed
the
online_store
branch
2 times, most recently
from
c60f7f9 to
c4d2c77
Compare
| @@ -75,8 +75,10 @@ class DatastoreOnlineStoreConfig(FeastConfigBaseModel): | |||
|
|
|||
| class DatastoreOnlineStore(OnlineStore): | |||
| """ | |||
| OnlineStore is an object used for all interaction between Feast and the service used for offline storage of | |||
| features. | |||
| Google Cloud Datastore implementation of the online store interface. | |||
There was a problem hiding this comment.
for this and redis, can you link to the corresponding reference doc on what the data model looks like? e.g. https://github.com/feast-dev/feast/blob/v0.23-branch/docs/specs/online_store_format.md#google-datastore-online-store-format
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -50,8 +50,7 @@ class SqliteOnlineStoreConfig(FeastConfigBaseModel): | |||
|
|
|||
| class SqliteOnlineStore(OnlineStore): | |||
| """ | |||
| OnlineStore is an object used for all interaction between Feast and the service used for offline storage of | |||
| features. | |||
| SQLite implementation of the online store interface. | |||
There was a problem hiding this comment.
Mention that this is not recommended in production?
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
felixwang9817
force-pushed
the
online_store
branch
from
3adbe83 to
17ed3e8
Compare
|
/lgtm |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #