Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Auto update yarn.lock as part of release #3059

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 10, 2022

What this PR does / why we need it:
There was an issue now that the release publishes new NPM packages for the UI as part of the flow. Roughly it's:

  1. Semantic release bumps file versions (including ui package version) and creates a tagged commit.
  2. When building the wheel, it needs to compile the Feast UI to bundle into the release. This updates the yarn.lock file because now there's a new published NPM version of the Feast UI.
  3. Because now the client is dirty with local changes, the built wheel is a dev wheel instead of a clean wheel (see https://github.com/pypa/setuptools_scm/#default-versioning-scheme).

This change instead now will publish the NPM release before running semantic release:

Then, Semantic release will additionally run make build-ui and check in the updated yarn.lock file before tagging the release
Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia force-pushed the fixReleaseProcess branch from 08dcfff to 1d25d12 Compare August 10, 2022 15:04
Copy link
Collaborator

@kevjumba kevjumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit e04ad63 into feast-dev:master Aug 10, 2022
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Aug 13, 2022
Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Francisco Javier Arceo <arceofrancisco@gmail.com>
@adchia adchia deleted the fixReleaseProcess branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants