Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve quickstart to include push features, batch scoring, odfv #3034

Merged
merged 11 commits into from
Aug 18, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Aug 8, 2022

What this PR does / why we need it:
This PR expands the default quickstart templates to include more functionality such as push features, multiple feature services, multiple ways of retrieving features, and on demand features.

It also moves the auto generated repository into a feature_repo folder, and adds READMEs in them on what else is needed to get to production. This is to prep for a future PR that includes GitHub actions that automatically apply definitions to a remote registry.

A followup will update the quickstart Colab to do some of the same things

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #3034 (87c43fe) into master (5b0cc87) will increase coverage by 8.86%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #3034      +/-   ##
==========================================
+ Coverage   66.93%   75.79%   +8.86%     
==========================================
  Files         173      207      +34     
  Lines       15056    17076    +2020     
==========================================
+ Hits        10077    12943    +2866     
+ Misses       4979     4133     -846     
Flag Coverage Δ
integrationtests 66.94% <12.50%> (+0.01%) ⬆️
unittests 58.26% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 85.47% <ø> (+3.61%) ⬆️
sdk/python/feast/feature_view.py 96.66% <ø> (ø)
sdk/python/tests/doctest/test_all.py 90.00% <80.00%> (+74.74%) ⬆️
sdk/python/feast/repo_operations.py 48.62% <100.00%> (+24.77%) ⬆️
sdk/python/tests/unit/cli/test_cli_chdir.py 100.00% <100.00%> (+81.48%) ⬆️
...k/python/tests/unit/local_feast_tests/test_init.py 100.00% <100.00%> (+81.08%) ⬆️
.../python/feast/infra/feature_servers/base_config.py 100.00% <0.00%> (ø)
...n/feast/infra/feature_servers/aws_lambda/config.py 100.00% <0.00%> (ø)
...thon/feast/infra/utils/postgres/postgres_config.py 100.00% <0.00%> (ø)
...b/cassandra_online_store/cassandra_online_store.py 2.63% <0.00%> (ø)
... and 112 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adchia adchia force-pushed the gitbook_test branch 5 times, most recently from efa5bc6 to d5b7aeb Compare August 16, 2022 13:37
@adchia adchia changed the title [WIP] docs: Improve quickstart to include push features, batch scoring, odfv docs: Improve quickstart to include push features, batch scoring, odfv Aug 17, 2022
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments, will do another pass later

docs/getting-started/concepts/registry.md Outdated Show resolved Hide resolved
docs/getting-started/quickstart.md Outdated Show resolved Hide resolved
docs/getting-started/quickstart.md Show resolved Hide resolved
docs/getting-started/quickstart.md Show resolved Hide resolved
docs/getting-started/quickstart.md Show resolved Hide resolved
adchia added 8 commits August 18, 2022 12:37
…n demand features, and batch scoring

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

sdk/python/feast/templates/gcp/README.md Show resolved Hide resolved
Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot feast-ci-bot removed the lgtm label Aug 18, 2022
@felixwang9817
Copy link
Collaborator

/lgtm

Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Aug 18, 2022
@adchia adchia added the lgtm label Aug 18, 2022
@adchia adchia merged commit 83c5efb into feast-dev:master Aug 18, 2022
@adchia adchia deleted the gitbook_test branch August 18, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants