-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve quickstart to include push features, batch scoring, odfv #3034
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3034 +/- ##
==========================================
+ Coverage 66.93% 75.79% +8.86%
==========================================
Files 173 207 +34
Lines 15056 17076 +2020
==========================================
+ Hits 10077 12943 +2866
+ Misses 4979 4133 -846
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
efa5bc6
to
d5b7aeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial comments, will do another pass later
sdk/python/feast/templates/snowflake/feature_repo/test_workflow.py
Outdated
Show resolved
Hide resolved
…n demand features, and batch scoring Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Signed-off-by: Danny Chiao <danny@tecton.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Danny Chiao <danny@tecton.ai>
/lgtm |
Signed-off-by: Danny Chiao <danny@tecton.ai>
New changes are detected. LGTM label has been removed. |
What this PR does / why we need it:
This PR expands the default quickstart templates to include more functionality such as push features, multiple feature services, multiple ways of retrieving features, and on demand features.
It also moves the auto generated repository into a
feature_repo
folder, and adds READMEs in them on what else is needed to get to production. This is to prep for a future PR that includes GitHub actions that automatically apply definitions to a remote registry.A followup will update the quickstart Colab to do some of the same things
Which issue(s) this PR fixes:
Fixes #