Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Functionality matrix for online stores #3007

Merged
merged 5 commits into from
Sep 2, 2022

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 changed the title docs: Functionality matrix for online stores docs: Functionality matrix for online stores [WIP] Aug 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Base: 66.85% // Head: 58.36% // Decreases project coverage by -8.48% ⚠️

Coverage data is based on head (1f1cc6b) compared to base (d7b0c52).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
- Coverage   66.85%   58.36%   -8.49%     
==========================================
  Files         175      209      +34     
  Lines       15848    17617    +1769     
==========================================
- Hits        10595    10283     -312     
- Misses       5253     7334    +2081     
Flag Coverage Δ
integrationtests ?
unittests 58.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.58%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adchia adchia self-assigned this Aug 10, 2022
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Sep 1, 2022
@felixwang9817 felixwang9817 changed the title docs: Functionality matrix for online stores [WIP] docs: Functionality matrix for online stores Sep 1, 2022
Signed-off-by: Danny Chiao <danny@tecton.ai>
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 219d04a into feast-dev:master Sep 2, 2022
adchia added a commit that referenced this pull request Sep 3, 2022
* Cleanup online store docs

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Add overview page

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Add Snowflake online store to RTD

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* Online store docs

Signed-off-by: Felix Wang <wangfelix98@gmail.com>

* add overiew to README in online store

Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Co-authored-by: Danny Chiao <danny@tecton.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants