-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update go.mod and go.sum but git restore before building #2883
Conversation
Signed-off-by: Achal Shah <achals@gmail.com>
@@ -76,6 +76,7 @@ jobs: | |||
make install-go-proto-dependencies | |||
make install-go-ci-dependencies | |||
git status | |||
git restore go.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a comment so ppl know why we're doing this.
Codecov Report
@@ Coverage Diff @@
## master #2883 +/- ##
===========================================
- Coverage 80.68% 59.34% -21.35%
===========================================
Files 176 176
Lines 15670 15670
===========================================
- Hits 12643 9299 -3344
- Misses 3027 6371 +3344
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Achal Shah <achals@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, kevjumba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #