-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Basic e2e test for go grpc server #2628
Conversation
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2628 +/- ##
==========================================
+ Coverage 81.39% 81.45% +0.06%
==========================================
Files 161 162 +1
Lines 13314 13380 +66
==========================================
+ Hits 10837 10899 +62
- Misses 2477 2481 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@@ -50,4 +50,4 @@ require ( | |||
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c // indirect | |||
) | |||
|
|||
replace github.com/go-python/gopy v0.4.0 => github.com/feast-dev/gopy v0.4.1-0.20220329011409-d705e6cd1d9b | |||
replace github.com/go-python/gopy v0.4.0 => github.com/feast-dev/gopy v0.4.1-0.20220429180328-4257ac71a4d0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved GIL handling, so that all go calls would release GIL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pyalex moskalenko.alexey@gmail.com
What this PR does / why we need it:
Very basic test (but better than nothing) that starts go feature server (GRPC) in a separate thread (since it's blocking) and checks (via grpc client) that it responses on GetOnlineFeatures requests.
Which issue(s) this PR fixes:
Fixes #