-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: List of avaliable online and offline stores exposed in test configuration #2625
Conversation
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2625 +/- ##
==========================================
- Coverage 81.66% 81.37% -0.30%
==========================================
Files 161 161
Lines 13307 13314 +7
==========================================
- Hits 10867 10834 -33
- Misses 2440 2480 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by what this PR accomplishes - how does it make it easier to specify a set of configs for a test?
sdk/python/tests/integration/feature_repos/repo_configuration.py
Outdated
Show resolved
Hide resolved
@felixwang9817
|
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex got it, I think this is fine for now so I'll stamp. In the long run it still feels quite awkward to set up a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: felixwang9817, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pyalex moskalenko.alexey@gmail.com
What this PR does / why we need it:
This will allow generating custom repo configs in specific test modules based on available online and offline stores.
Which issue(s) this PR fixes:
Fixes #