CR

Signed-off-by: Achal Shah <achals@gmail.com>

CONTRIBUTING.md

@@ -176,6 +176,7 @@ The services with containerized replacements currently implemented are:
 - Datastore
 - DynamoDB
 - Redis
+- Trino
 
 You can run `make test-python-integration-container` to run tests against the containerized versions of dependencies.
 

sdk/python/feast/batch_feature_view.py

@@ -1,11 +1,10 @@
 from datetime import timedelta
 from typing import Dict, List, Optional, Union
 
-from google.protobuf.duration_pb2 import Duration
-
-from feast import Entity, Feature, Field
 from feast.data_source import DataSource
+from feast.entity import Entity
 from feast.feature_view import FeatureView
+from feast.field import Field
 from feast.protos.feast.core.DataSource_pb2 import DataSource as DataSourceProto
 
 SUPPORTED_BATCH_SOURCES = {
@@ -24,8 +23,7 @@ def __init__(
         *,
         name: Optional[str] = None,
         entities: Optional[Union[List[Entity], List[str]]] = None,
-        ttl: Optional[Union[Duration, timedelta]] = None,
-        features: Optional[List[Feature]] = None,
+        ttl: Optional[timedelta] = None,
         tags: Optional[Dict[str, str]] = None,
         online: bool = True,
         description: str = "",
@@ -51,7 +49,6 @@ def __init__(
             ttl=ttl,
             batch_source=None,
             stream_source=None,
-            features=features,
             tags=tags,
             online=online,
             description=description,

sdk/python/feast/stream_feature_view.py

@@ -1,11 +1,10 @@
 from datetime import timedelta
 from typing import Dict, List, Optional, Union
 
-from google.protobuf.duration_pb2 import Duration
-
-from feast import Entity, Feature, Field
 from feast.data_source import DataSource
+from feast.entity import Entity
 from feast.feature_view import FeatureView
+from feast.field import Field
 from feast.protos.feast.core.DataSource_pb2 import DataSource as DataSourceProto
 
 SUPPORTED_STREAM_SOURCES = {
@@ -20,8 +19,7 @@ def __init__(
         *,
         name: Optional[str] = None,
         entities: Optional[Union[List[Entity], List[str]]] = None,
-        ttl: Optional[Union[Duration, timedelta]] = None,
-        features: Optional[List[Feature]] = None,
+        ttl: Optional[timedelta] = None,
         tags: Optional[Dict[str, str]] = None,
         online: bool = True,
         description: str = "",
@@ -47,7 +45,6 @@ def __init__(
             ttl=ttl,
             batch_source=None,
             stream_source=None,
-            features=features,
             tags=tags,
             online=online,
             description=description,

sdk/python/tests/unit/test_feature_views.py

@@ -2,9 +2,9 @@
 
 import pytest
 
-from feast import KafkaSource
 from feast.batch_feature_view import BatchFeatureView
 from feast.data_format import AvroFormat
+from feast.data_source import KafkaSource
 from feast.infra.offline_stores.file_source import FileSource
 from feast.stream_feature_view import StreamFeatureView