Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Timestamp update #2486

Merged
merged 13 commits into from
Apr 6, 2022
Merged

fix: Timestamp update #2486

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3c2f776
Timestamps
kevjumba Apr 1, 2022
bba6b02
Fix
kevjumba Apr 4, 2022
22fa4ce
Update md files
kevjumba Apr 4, 2022
a7e85ca
Update more
kevjumba Apr 4, 2022
cde6af0
Update batch source creators
kevjumba Apr 4, 2022
245dc19
Fix
kevjumba Apr 4, 2022
dab8982
Fix data source
kevjumba Apr 4, 2022
ac6689b
Fix
kevjumba Apr 4, 2022
db6cbb1
fix
kevjumba Apr 5, 2022
c871a59
Fix
kevjumba Apr 5, 2022
1f16637
Fix
kevjumba Apr 5, 2022
d98720c
Temp fix
kevjumba Apr 5, 2022
ad141af
Fixed
kevjumba Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 5, 2022
commit c871a59d4a8494ebf28b4a89d492c5b48e812184
2 changes: 0 additions & 2 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,6 @@ def __init__(
UserWarning,
)
self.name = name or ""
if event_timestamp_column is None and timestamp_field is None:
raise ValueError('No "timestamp_field" argument is provided to Datasource')
if not timestamp_field and event_timestamp_column:
warnings.warn(
(
Expand Down