Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for push sources in feature views #2452

Merged
merged 6 commits into from
Mar 25, 2022
Merged

chore: Add support for push sources in feature views #2452

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1756a14
chore: Add support for push sources in feature views
achals Mar 25, 2022
fbea6a8
merge from master
achals Mar 25, 2022
1840abb
fix test
achals Mar 25, 2022
5002ef0
cr
achals Mar 25, 2022
8bf8b84
Add universal test
achals Mar 25, 2022
0a42623
cr
achals Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge from master 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Mar 25, 2022
commit fbea6a8640481827f52abced57a3210a1c83a45b
2 changes: 1 addition & 1 deletion go/internal/feast/featurestore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ func groupFeatureRefs(requestedFeatureViews []*featureViewAndRefs,
joinKeys := make([]string, 0)
fv := featuresAndView.view
featureNames := featuresAndView.featureRefs
for entity, _ := range fv.entities {
for entity := range fv.entities {
joinKeys = append(joinKeys, entityNameToJoinKeyMap[entity])
}

Expand Down
7 changes: 5 additions & 2 deletions sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ class FeatureView(BaseFeatureView):
ttl: timedelta
batch_source: DataSource
stream_source: Optional[DataSource]

features: List[Feature]
online: bool
description: str
tags: Dict[str, str]
owner: str
materialization_intervals: List[Tuple[datetime, datetime]]

@log_exceptions
Expand Down Expand Up @@ -160,7 +164,6 @@ def __init__(

self.online = online
self.stream_source = stream_source
self.online = online
self.materialization_intervals = []

# Note: Python requires redefining hash in child classes that override __eq__
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.