Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't prevent apply from running given duplicate empty names in data sources. Also fix repeated apply of Spark data source. #2415

Merged
merged 15 commits into from
Mar 29, 2022
Rate limit · GitHub

Whoa there!

You have triggered an abuse detection mechanism.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Merged

fix: Don't prevent apply from running given duplicate empty names in data sources. Also fix repeated apply of Spark data source. #2415

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2db0c9a
fix: Print more warning statements on requirement for data sources to…
adchia Mar 17, 2022
2d4fc84
typo
adchia Mar 17, 2022
88a7434
typo
adchia Mar 17, 2022
ba97190
fix
adchia Mar 17, 2022
cdee46c
fix
adchia Mar 17, 2022
3a4b4cd
fix
adchia Mar 17, 2022
7add51a
More tests
adchia Mar 21, 2022
bc9d3ae
fix
adchia Mar 29, 2022
9d2c5f1
fix
adchia Mar 29, 2022
bae2e37
fix
adchia Mar 29, 2022
41ff4d9
fix
adchia Mar 29, 2022
70d4b8d
revert
adchia Mar 29, 2022
e17973f
fix
adchia Mar 29, 2022
0fe2df8
fix
adchia Mar 29, 2022
f854de4
fix
adchia Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix 
Signed-off-by: Danny Chiao <danny@tecton.ai>
Rate limit · GitHub

Whoa there!

You have triggered an abuse detection mechanism.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

@adchia
adchia committed Mar 29, 2022
commit 3a4b4cdd0ccd2701c6898b52ce397eea66a3124d
52 changes: 26 additions & 26 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Original file line number Diff line number Diff line change
@@ -66,42 +66,42 @@
# module will be imported and FULL_REPO_CONFIGS will be extracted from the file.
DEFAULT_FULL_REPO_CONFIGS: List[IntegrationTestRepoConfig] = [
# Local configurations
# IntegrationTestRepoConfig(),
# IntegrationTestRepoConfig(python_feature_server=True),
IntegrationTestRepoConfig(),
IntegrationTestRepoConfig(python_feature_server=True),
]
if os.getenv("FEAST_IS_LOCAL_TEST", "False") != "True":
DEFAULT_FULL_REPO_CONFIGS.extend(
[
# IntegrationTestRepoConfig(online_store=REDIS_CONFIG),
IntegrationTestRepoConfig(online_store=REDIS_CONFIG),
# GCP configurations
IntegrationTestRepoConfig(
provider="gcp",
offline_store_creator=BigQueryDataSourceCreator,
online_store="datastore",
),
# IntegrationTestRepoConfig(
# provider="gcp",
# offline_store_creator=BigQueryDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
# # AWS configurations
# IntegrationTestRepoConfig(
# provider="aws",
# offline_store_creator=RedshiftDataSourceCreator,
# online_store=DYNAMO_CONFIG,
# python_feature_server=True,
# ),
# IntegrationTestRepoConfig(
# provider="aws",
# offline_store_creator=RedshiftDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
# # Snowflake configurations
# IntegrationTestRepoConfig(
# provider="aws", # no list features, no feature server
# offline_store_creator=SnowflakeDataSourceCreator,
# online_store=REDIS_CONFIG,
# ),
IntegrationTestRepoConfig(
provider="gcp",
offline_store_creator=BigQueryDataSourceCreator,
online_store=REDIS_CONFIG,
),
# AWS configurations
IntegrationTestRepoConfig(
provider="aws",
offline_store_creator=RedshiftDataSourceCreator,
online_store=DYNAMO_CONFIG,
python_feature_server=True,
),
IntegrationTestRepoConfig(
provider="aws",
offline_store_creator=RedshiftDataSourceCreator,
online_store=REDIS_CONFIG,
),
# Snowflake configurations
IntegrationTestRepoConfig(
provider="aws", # no list features, no feature server
offline_store_creator=SnowflakeDataSourceCreator,
online_store=REDIS_CONFIG,
),
]
)
full_repo_configs_module = os.environ.get(FULL_REPO_CONFIGS_MODULE_ENV_NAME)