Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on demand feature views deletion #2203

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

corentinmarek
Copy link
Contributor

@corentinmarek corentinmarek commented Jan 7, 2022

The deletion of on demand feature views is broken as it is not covered in registry.delete_feature_view.
This is a small fix to cover deletion of odfv the same way it is done for standard or request feature views.

Does this PR introduce a user-facing change?:

NONE

@corentinmarek corentinmarek requested a review from a team as a code owner January 7, 2022 14:09
@corentinmarek corentinmarek requested review from adchia and removed request for a team January 7, 2022 14:09
@feast-ci-bot
Copy link
Collaborator

Hi @corentinmarek. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: corentinmarek <corentin.marek@gmail.com>
@achals
Copy link
Member

achals commented Jan 7, 2022

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #2203 (a589ca4) into master (4c32d75) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
- Coverage   84.55%   84.47%   -0.08%     
==========================================
  Files         104      104              
  Lines        8286     8292       +6     
==========================================
- Hits         7006     7005       -1     
- Misses       1280     1287       +7     
Flag Coverage Δ
integrationtests 74.25% <0.00%> (-0.35%) ⬇️
unittests 58.87% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/registry.py 83.60% <0.00%> (-1.68%) ⬇️
.../integration/online_store/test_universal_online.py 97.67% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c32d75...a589ca4. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, corentinmarek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants