Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflow to include new docker images #2108

Merged
merged 7 commits into from
Dec 8, 2021

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Dec 6, 2021

What this PR does / why we need it:
There are new feature transformation server, lambda feature server, and java feature server docker images. This adds convenience commands in the Makefile + merges/updates our release workflow to build + push these images to GCR/dockerhub.

This also removes a workflow that builds a new FTS image + tags against the commit. We don't use this (the helm charts don't point to these either).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@adchia adchia requested a review from a team as a code owner December 6, 2021 04:45
@adchia adchia requested review from woop and removed request for a team December 6, 2021 04:45
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #2108 (e9ea973) into master (a63097f) will decrease coverage by 25.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2108       +/-   ##
===========================================
- Coverage   83.51%   57.99%   -25.52%     
===========================================
  Files         100      100               
  Lines        8088     8088               
===========================================
- Hits         6755     4691     -2064     
- Misses       1333     3397     +2064     
Flag Coverage Δ
integrationtests ?
unittests 57.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/constants.py 100.00% <100.00%> (ø)
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
.../integration/online_store/test_universal_online.py 15.34% <0.00%> (-82.33%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 35.00% <0.00%> (-65.00%) ⬇️
...s/integration/registration/test_universal_types.py 36.00% <0.00%> (-64.00%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63097f...e9ea973. Read the comment docs.

@adchia adchia requested review from pyalex and tsotnet and removed request for woop December 6, 2021 05:10
Makefile Outdated Show resolved Hide resolved
@pyalex
Copy link
Collaborator

pyalex commented Dec 7, 2021

/lgtm

@feast-ci-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@feast-ci-bot feast-ci-bot removed the lgtm label Dec 7, 2021
…ase workflows. Add/update docker images for lambda feature server, FTS, and java feature server

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, pyalex, tsotnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@tsotnet tsotnet added the lgtm label Dec 8, 2021
@feast-ci-bot feast-ci-bot merged commit 5ab6232 into feast-dev:master Dec 8, 2021
@adchia adchia deleted the releaseUpdates branch March 4, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants