Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change internal references from input to batch_source #1729

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Change internal references from input to batch_source #1729

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2eb7610
Change internal references from input to batch_source
felixwang9817 Jul 22, 2021
7bccac4
Add deprecation warning
felixwang9817 Jul 22, 2021
7713a9a
Change deprecation release to 0.12
felixwang9817 Jul 23, 2021
cd0c62d
Change deprecation release to 0.13
felixwang9817 Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change deprecation release to 0.12 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Jul 23, 2021
commit 7713a9ad206d7afc356f9ea45ebd2d0c245a37a1
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def __init__(
warnings.warn(
Copy link
Contributor

@tedhtchang tedhtchang Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixwang9817 Should we warn users only when the input is assigned ?

Copy link
Collaborator Author

@felixwang9817 felixwang9817 Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedhtchang That's a good point, I think ideally we would have done that. However, given that (a) input was a required parameter before this change, so almost all users will continue to use input, and (b) releases are fairly frequent so this deprecation warning will soon become outdated, I think we can leave this change as is.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedhtchang btw, I managed to insert this change into a separate PR (#1746). Thanks for pointing this one out!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixwang9817 Thanks. Looks good.

(
"The argument 'input' is being deprecated. Please use 'batch_source' "
"instead. Feast 0.11.3 and onwards will not support the argument 'input'."
"instead. Feast 0.12 and onwards will not support the argument 'input'."
felixwang9817 marked this conversation as resolved.
Show resolved Hide resolved
),
DeprecationWarning,
)
Expand Down