Update Feast Core list features method #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
terryyylim
force-pushed
the
update-list-features
branch
from
f3c2a1c to
6adcf71
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
update-list-features
branch
from
6adcf71 to
18bd370
Compare
|
/retest |
pyalex
reviewed
Nov 19, 2020
| @@ -1359,7 +1386,7 @@ public void shouldReturnNoTables() { | |||
| StatusRuntimeException.class, | |||
| () -> apiClient.simpleGetFeatureTable(projectName, featureTableName)); | |||
|
|
|||
| assertThat(featureTables.size(), equalTo(0)); | |||
| assertThat(featureTables.size(), equalTo(1)); | |||
There was a problem hiding this comment.
The test is called "should ReturnNoTables", isn't there contradiction?
pyalex
reviewed
Nov 19, 2020
pyalex
reviewed
Nov 19, 2020
| * @param features List of features to insert to map. | ||
| * @return Map of featureRef:feature. | ||
| */ | ||
| public Map<String, FeatureV2> getFeaturesRefToFeaturesMap(List<FeatureV2> features) { |
There was a problem hiding this comment.
why this method is public? Seems that it's being only used by getFeaturesByRef
pyalex
reviewed
Nov 19, 2020
| * @param featureReference to render as string | ||
| * @return string representation of feature reference. | ||
| */ | ||
| public static String renderFeatureRef(ServingAPIProto.FeatureReferenceV2 featureReference) { |
There was a problem hiding this comment.
Do we need this method? It just wraps single function call
pyalex
reviewed
Nov 19, 2020
| * @param labelsFilter contain labels that should be attached to FeatureTable's features | ||
| * @return Map of Feature references and Features | ||
| */ | ||
| public Map<String, FeatureV2> getFeaturesByRef(Map<String, String> labelsFilter) { |
There was a problem hiding this comment.
Name is a little bit confusing. It looks more like getFeaturesByLabels
pyalex
reviewed
Nov 19, 2020
| @@ -311,11 +328,15 @@ public void shouldUseDefaultProjectIfProjectUnspecified() { | |||
| .build(); | |||
| List<FeatureTableProto.FeatureTable> featureTables = | |||
| apiClient.simpleListFeatureTables(filter); | |||
| System.out.println(featureTables); | |||
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
pyalex
approved these changes
Nov 20, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, terryyylim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently,
listFeaturesmethod is not updated to return features from feature tables, but rather feature sets.This PR includes:
ListFeaturesResponseprotoSpecServiceto retrieve features from feature tablesWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: