helm update: jobservice secrets

Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>

infra/charts/feast/charts/feast-jobservice/templates/deployment.yaml

@@ -37,40 +37,32 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
 
-      {{- if .Values.gcpServiceAccount.enabled }}
+      {{- if Values.secrets }}
       volumes:
-      - name: {{ template "feast-jobservice.fullname" . }}-gcp-service-account
+      {{ - range $secret := .Values.secrets }}
+      - name: {{ $secret }}
         secret:
-          secretName: {{ .Values.gcpServiceAccount.existingSecret.name }}
+          secretName: {{ $secret }}
+      {{ - end }}
       {{- end }}
 
       containers:
       - name: {{ .Chart.Name }}
         image: {{ .Values.image.repository }}:{{ .Values.image.tag }}
         imagePullPolicy: {{ .Values.image.pullPolicy }}
 
-        {{- if .Values.gcpServiceAccount.enabled }}
+        {{- if .Values.secrets }}
         volumeMounts:
-        - name: {{ template "feast-jobservice.fullname" . }}-gcp-service-account
-          mountPath: /etc/secrets/google
+        {{ - range $secret := .Values.secrets }}
+        - name: {{ $secret }}
+          mountPath: "/etc/secrets/{{ $secret }}"
           readOnly: true
+        {{ - end }}
         {{- end }}
 
         env:
         - name: FEAST_CORE_URL
           value: "{{ .Release.Name }}-feast-core:6565"
-        - name: FEAST_HISTORICAL_SERVING_URL
-          value: "{{ .Release.Name }}-feast-batch-serving:6566"
-
-        {{- if .Values.gcpServiceAccount.enabled }}
-        - name: GOOGLE_APPLICATION_CREDENTIALS
-          value: /etc/secrets/google/{{ .Values.gcpServiceAccount.existingSecret.key }}
-        {{- end }}
-
-        {{- if .Values.gcpProjectId }}
-        - name: GOOGLE_CLOUD_PROJECT
-          value: {{ .Values.gcpProjectId | quote }}
-        {{- end }}
 
         {{- range $key, $value := .Values.envOverrides }}
         - name: {{ printf "%s" $key | replace "." "_" | upper | quote }}

infra/docker/jobservice/Dockerfile

@@ -16,7 +16,7 @@ RUN make compile-protos-python
 # Install Feast SDK
 COPY .git .git
 COPY README.md README.md
-RUN pip install -e sdk/python -U
+RUN pip install -U -e sdk/python
 RUN pip install "s3fs" "boto3" "urllib3>=1.25.4"
 
 #

sdk/python/feast/constants.py

@@ -147,6 +147,7 @@ class AuthProvider(Enum):
     CONFIG_STATSD_PORT: "0",
     # IngestionJob DeadLetter Destination
     CONFIG_DEADLETTER_PATH: "",
-    # ProtoRegistry Address
+    # ProtoRegistry Address (currently only Stencil Server is supported as registry)
+    # https://github.com/gojekfarm/stencil
     CONFIG_STENCIL_URL: "",
 }