Prevent creating feature with new type upon deleting feature from feature table #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Terence <terencelimxp@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: terryyylim The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
terryyylim
changed the title
|
Are you going to add tests? |
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
force-pushed
the
fix-feature-type-update
branch
from
d3c2168 to
c6499b1
Compare
Signed-off-by: Terence <terencelimxp@gmail.com>
Signed-off-by: Terence <terencelimxp@gmail.com>
terryyylim
requested review from
davidheryanto,
khorshuheng,
pyalex and
woop
as code owners
|
/retest |
|
Closing this PR since we're moving towards allowing type changes to features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Terence terencelimxp@gmail.com
What this PR does / why we need it:
A bug was introduced in Feature Table API PR, which has an issue tracking it as shown below. This PR adds archiving of feature possible, to prevent feature types from being changed upon deletion.
Which issue(s) this PR fixes:
Fixes #1070
Does this PR introduce a user-facing change?: