Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to_df() to OnlineResponse #1613

Closed
woop opened this issue Jun 2, 2021 · 4 comments · Fixed by #1623
Closed

Add to_df() to OnlineResponse #1613

woop opened this issue Jun 2, 2021 · 4 comments · Fixed by #1623
Labels
kind/feature New feature or request priority/p1

Comments

@woop
Copy link
Member

woop commented Jun 2, 2021

We need to provide a Pandas Dataframe based return type from get_online_features() for consistency with get_historical_features().
@woop woop added priority/p1 kind/feature New feature or request labels Jun 2, 2021
@tedhtchang
Copy link
Contributor

tedhtchang commented Jun 4, 2021 •
edited
Loading

@woop You mean adding a method to_df() to the class OnlineResponse so we call call get_online_features(...).to_df() ?

@woop
Copy link
Member Author

woop commented Jun 5, 2021

yea, something like that.

@tedhtchang
Copy link
Contributor

@woop I will work on it if no one is working on it.

@woop
Copy link
Member Author

woop commented Jun 5, 2021

Sure, that would be great :)

@tedhtchang tedhtchang mentioned this issue Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add to_df() to convert get_online_feature response to pandas dataframe tedhtchang/feast
2 participants
@woop @tedhtchang