-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to_df() to convert get_online_feature response to pandas dataframe #1623
Add to_df() to convert get_online_feature response to pandas dataframe #1623
Conversation
Hi @tedhtchang. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
==========================================
+ Coverage 83.39% 83.47% +0.08%
==========================================
Files 71 71
Lines 6113 6144 +31
==========================================
+ Hits 5098 5129 +31
Misses 1015 1015
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Rerunning the tests now. Codecov has a bug that I tried to fix. You may need to rebase on master. 3b22005 |
Thanks @tedhtchang, this is great! |
0b4fffd
to
12d7eac
Compare
Thanks @tedhtchang |
Signed-off-by: ted chang <htchang@us.ibm.com>
12d7eac
to
5ada579
Compare
Signed-off-by: ted chang <htchang@us.ibm.com>
5ada579
to
77cda24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, tedhtchang, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ted chang htchang@us.ibm.com
What this PR does / why we need it:
Convert online response to Panda dataframe
Which issue(s) this PR fixes:
Fixes #1613
Does this PR introduce a user-facing change?: