Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_df() to convert get_online_feature response to pandas dataframe #1623

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

tedhtchang
Copy link
Contributor

Signed-off-by: ted chang htchang@us.ibm.com

What this PR does / why we need it:
Convert online response to Panda dataframe

Which issue(s) this PR fixes:
Fixes #1613

Does this PR introduce a user-facing change?:

Users can convert online feature response to Panda dataframe

@feast-ci-bot
Copy link
Collaborator

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@achals
Copy link
Member

achals commented Jun 7, 2021

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #1623 (77cda24) into master (b32e766) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   83.39%   83.47%   +0.08%     
==========================================
  Files          71       71              
  Lines        6113     6144      +31     
==========================================
+ Hits         5098     5129      +31     
  Misses       1015     1015              
Flag Coverage Δ
integrationtests 83.39% <100.00%> (+0.08%) ⬆️
unittests 76.57% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 92.95% <ø> (ø)
sdk/python/feast/online_response.py 97.43% <100.00%> (+0.21%) ⬆️
sdk/python/tests/test_online_retrieval.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32e766...77cda24. Read the comment docs.

@woop
Copy link
Member

woop commented Jun 7, 2021

Rerunning the tests now. Codecov has a bug that I tried to fix. You may need to rebase on master. 3b22005

@woop woop added the kind/feature New feature or request label Jun 7, 2021
@woop
Copy link
Member

woop commented Jun 7, 2021

Thanks @tedhtchang, this is great!

@tedhtchang tedhtchang force-pushed the get-online-feature-to-df branch from 0b4fffd to 12d7eac Compare June 10, 2021 02:06
@woop
Copy link
Member

woop commented Jun 11, 2021

Thanks @tedhtchang

sdk/python/tests/test_online_retrieval.py Outdated Show resolved Hide resolved
Signed-off-by: ted chang <htchang@us.ibm.com>
@tedhtchang tedhtchang force-pushed the get-online-feature-to-df branch from 12d7eac to 5ada579 Compare June 14, 2021 21:09
Signed-off-by: ted chang <htchang@us.ibm.com>
@tedhtchang tedhtchang force-pushed the get-online-feature-to-df branch from 5ada579 to 77cda24 Compare June 14, 2021 21:11
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, tedhtchang, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d71b452 into feast-dev:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to_df() to OnlineResponse
5 participants