Don't materialize FeatureViews where (#2101)

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
feast-dev · Dec 2, 2021 · e6ed3cb · e6ed3cb
1 parent 73ec64d
commit e6ed3cb
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -758,9 +758,16 @@ def materialize_incremental(
             feature_views_to_materialize = self._list_feature_views(
                 hide_dummy_entity=False
             )
+            feature_views_to_materialize = [
+                fv for fv in feature_views_to_materialize if fv.online
+            ]
         else:
             for name in feature_views:
                 feature_view = self._get_feature_view(name, hide_dummy_entity=False)
+                if not feature_view.online:
+                    raise ValueError(
+                        f"FeatureView {feature_view.name} is not configured to be served online."
+                    )
                 feature_views_to_materialize.append(feature_view)
 
         _print_materialization_log(
@@ -850,9 +857,16 @@ def materialize(
             feature_views_to_materialize = self._list_feature_views(
                 hide_dummy_entity=False
             )
+            feature_views_to_materialize = [
+                fv for fv in feature_views_to_materialize if fv.online
+            ]
         else:
             for name in feature_views:
                 feature_view = self._get_feature_view(name, hide_dummy_entity=False)
+                if not feature_view.online:
+                    raise ValueError(
+                        f"FeatureView {feature_view.name} is not configured to be served online."
+                    )
                 feature_views_to_materialize.append(feature_view)
 
         _print_materialization_log(