Conversation
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
…treamAsync Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
…yStreamAsync Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR lays groundwork for the v1.0.0 release by updating tests, introducing a new stream-reset API, enriching NuGet package metadata, and automating the release workflow.
- Refactor tests to assert stream position resets
- Add
ResetStreamPositionAPI and call it after copy operations - Enhance project files with descriptions and release notes (incl. typos to fix)
- Introduce a GitHub Actions workflow for publishing to NuGet
Reviewed Changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/.../CopyToTemporaryStreamTests.cs | Replaced NotBeNull assertions with Position == 0 checks |
| src/Light.TemporaryStreams.Core/TemporaryStreamServiceExtensions.cs & TemporaryStream.cs | Added ResetStreamPosition method and calls |
| src/Light.TemporaryStreams/Light.TemporaryStreams.csproj | Added <Decscription> and <PackageReleaseNotes> |
| src/Light.TemporaryStreams.Core/Light.TemporaryStreams.Core.csproj | Added <Description> and <PackageReleaseNotes> |
| .github/workflows/release-on-nuget.yml | New workflow to pack and push packages to NuGet |
Comments suppressed due to low confidence (1)
.github/workflows/release-on-nuget.yml:24
- The shell command is using
>instead of a pipe; it should beecho "$SNK" | base64 --decode > Light.TemporaryStreams.snkto correctly decode the SNK file.
run: echo "$SNK" > base64 --decode > Light.TemporaryStreams.snk
src/Light.TemporaryStreams.Core/Light.TemporaryStreams.Core.csproj
Outdated
Show resolved
Hide resolved
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the project, focusing on build optimization, release automation, and metadata updates. Key changes include the creation of a reusable GitHub Action for caching NuGet packages, the addition of a workflow for publishing releases to NuGet, and updates to project properties for better package metadata.
Build Optimization:
.github/actions/cache-nuget/action.yml: Created a composite GitHub Action to cache NuGet packages, improving build speed by reusing package dependencies across workflows..github/workflows/build-and-test.yml: Updated the build and test workflow to use the newcache-nugetaction instead of directly invokingactions/cache.Release Automation:
.github/workflows/release-on-nuget.yml: Added a new workflow to automate the release process on NuGet, including steps for code checkout, dependency caching, SNK file preparation, package creation, and pushing to NuGet.Metadata Updates:
Directory.Build.props: Added metadata properties such asAuthors,Company,Copyright,RootNamespace, andVersionto improve NuGet package details. Enabled treating warnings as errors inReleasebuilds for stricter code quality.Directory.Packages.props: Added theMicrosoft.SourceLink.GitHubpackage to enable source link support for NuGet packages.Solution Structure:
Light.TemporaryStreams.sln: Updated the solution file to include the newcache-nugetaction andrelease-on-nuget.ymlworkflow, ensuring proper integration into the project structure. [1] [2] [3]