Skip to content

Commit

Permalink
Fix the syntax-lint and metadata_lint errors
Browse files Browse the repository at this point in the history
Missing commas and arrows in the pp-files
Removing pe-requirement and type for requirement
  • Loading branch information
ralfbosz committed May 2, 2018
1 parent d7de6d5 commit d0fc76c
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 13 deletions.
4 changes: 2 additions & 2 deletions manifests/config.pp
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
# }
rhsm_config { '/etc/rhsm/rhsm.conf':
ensure => present,
* => $::subscription_manager::config_hash
* => $::subscription_manager::config_hash,
}

# Four cases
Expand All @@ -67,7 +67,7 @@
rhsm_register { $::subscription_manager::server_hostname:
ensure => present,
require => Rhsm_config['/etc/rhsm/rhsm.conf'],
* => $_settings
* => $_settings,
}
}

Expand Down
8 changes: 4 additions & 4 deletions manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@
# limit use to supported Operating Systems
case $::facts['os']['family'] {
'RedHat', 'CentOS', 'Scientific', 'Fedora': {
class { '::subscription_manager::install': } ->
class { '::subscription_manager::config': } ~>
class { '::subscription_manager::service': } ->
Class['::subscription_manager']
class { '::subscription_manager::install': }
-> class { '::subscription_manager::config': }
~> class { '::subscription_manager::service': }
-> Class['::subscription_manager']
}
default: {
notify { "${::facts['os']['description']} not supported by subscription_manager": }
Expand Down
4 changes: 2 additions & 2 deletions manifests/install.pp
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
if $::subscription_manager::repo != '' and
$::subscription_manager::repo != undef {
contain $::subscription_manager::repo
Class[ $::subscription_manager::repo ] ->
Package[ $::subscription_manager::package_names ]
Class[ $::subscription_manager::repo ]
-> Package[ $::subscription_manager::package_names ]
}

# shorten several really long names
Expand Down
6 changes: 1 addition & 5 deletions metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"dependencies": [
{
"name": "puppetlabs/transition",
"version_requiement": ">= 0.1.0 < 1.0.0"
"version_requirement": ">= 0.1.0 < 1.0.0"
},
{
"name": "puppet/boolean",
Expand Down Expand Up @@ -48,10 +48,6 @@
}
],
"requirements": [
{
"name": "pe",
"version_requirement": ">= 2015.5.1"
},
{
"name": "puppet",
"version_requirement": ">= 4.5.0"
Expand Down

0 comments on commit d0fc76c

Please sign in to comment.