Skip to content

FDP SHACL inconsistencies #30

Description

@dennisvang

The SHACL for the FDP metadata in v1.2 has a few inconsistencies w.r.t. the definition in the [metadata schema table]:

  1. missing sh:maxCount value (should be 1) actually the whole dct;hasVersion is not mentioned in the FDP table:
  2. ambiguity in definition of fdp-o:metadataIdentifier property:
    ], [
    sh:path fdp-o:metadataIdentifier ;
    sh:nodeKind sh:IRI ;
    sh:maxCount 1 ;
    sh:minCount 1 ;
    ], [

    vs
    ], [
    sh:path fdp-o:metadataIdentifier ;
    sh:datatype xsd:dateTime ;
    sh:maxCount 1 ;
    sh:minCount 1 ;
    ], [

    the latter should probably be fdp-o:metadataModified, according to the table in 4.2.1
  3. wrong prefix for conformsToFdpSpec (dct should be fdp-o):
    sh:path dct:conformsToFdpSpec ;
  4. the SHACL file defines a FAIRDataPointContainerShape but does not use it, nor does the spec provide a clear indication of how to use it
    :FAIRDataPointContainerShape a sh:NodeShape ;

    The "example" suggests the FDP itself is not an LDP container, and the catalog container is a completely separate resource, only connected to the FDP via the ldp:membershipResource predicate:
    <https://purl.org/fairdatapoint/app/catalog/> a ldp:DirectContainer ;
    dct:title "Catalogs" ;
    ldp:membershipResource <https://fairdatapoint.org/app> ;
  5. the SHACL shape requires at least one fdp-o:metadataCatalog to be present, but this predicate is not mentioned at all in the [metadata schema table] (only in the LDP table). Moreover, the cardinality implies we're not allowed to create an empty FDP and would need to create a placeholder catalog instead (e.g. the reference implementation does not comply)
    ], [
    sh:path fdp-o:metadataCatalog ;
    sh:node :CatalogShape ;
    sh:minCount 1;
    ], [
  6. dcat:endPointDescription is in the table but is missing from the SHACL
    [metadata schema table]: https://github.com/fdp-specs/fdp-specs.github.io/blob/5e122bf192b431afe5034c71379f8522e1cbb227/src/tables/table-fdp-metadata.html

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions