Impossible to disable the new source control action bar

[gene-pavlovsky]

I found myself never saying "yes" to the new "Would you like to add this file to version control?" action bar.
It's actually starting to bother me, and I'd like to disable it.
SourceControl has one setting "Never create a commit when moving, deleting, etc.", I have it checked.
However, when I try to delete something, for example, I get a confirm dialog "would you like to remove the file(s) from version control". So the setting doesn't appear to be working.
I'd like to know what is "etc." - is it supposed to include adding a file (and so the add to version control action bar)? If yes, it's also broken. If not, I think an extra setting to be able to disable the action bar is needed.

[Neverbirth]

@chipshort ??? Although I guess this would be an easy fix.

[elsassph]

Does these "add/remove to CSV" do irreversible operations? That would be harmful.
git add thefile or git rm thefile are normally fairly painless because they only stage the changes.

[gene-pavlovsky]

Perhaps that's what the "never create a commit" setting does - prevents from creating commits, but doesn't turn off staging/unstaging. I agree that it's not harmful, but personally I prefer to review all my changes when I'm ready to commit, then stage what I want myself. So I think a setting to disable these new and nice (surely wonderful for many people) features is still needed for others who don't want all or some of them.

[elsassph]

Commiting should never be done, imho. It shouldn't even be an option.

[gene-pavlovsky]

I think you have a point. It's not very common use case to create single commit for every moved/deleted file (and completely pointless for a newly added file which doesn't contain anything useful yet).

[chipshort]

So to clarify a bit:
The add bar does not do anything irreversible. It just stages the file.
Since it does not create a commit, it is not affected by the "Never create a commit when moving, deleting, etc." flag. That setting is basically, so you do not constantly get asked if you want to commit, if you do not want to use the feature. Adding a setting for the add bar should be easy.
As for the usefulness, I would not personally use it, but I can see that it might be useful for some.
@Neverbirth asked for these features, so maybe he can explain a bit more.

Personally, I actually do not like the way the whole version control integration in FD works. I am more a fan of the way it's done in VS Code, for example, where you basically have a panel with all the changes, can look at the diffs, stage files, commit and push (but that's just my personal taste and would be quite a bit of work).

[gene-pavlovsky]

I'm sure the blue bar is useful to many people. But it would be good if it can be enable/disabled. I'm getting more and more frustrated by various apps (browsers do it a lot with "allow location/notifications/etc ?", and these days websites with their "accept cookies") bothering you with some questions sliding from the top, bottom or wherever.

I didn't check how VS code does source control, but what you describe sounds more useful than the current implementation. Personally I mostly prefer to check my changes with either command-line git commands, or TortoiseGit commit dialog.

[Neverbirth]

The motivation for the work is quite obvious: have more integrated source control inside the IDE so the chances for making wrong commits are mitigated. It's not uncommon (I would say quite common) to find commits missing files, or renaming of files that are a Delete and Add operation instead of a proper Rename/Move one.

Implementation details like the ones commented here were never discussed. I agree that actions shouldn't create a commit and that being able to hide the message bar would be welcome (but I can say that I like it and I saw some other IDEs that can be more intrusive in this case).

Also, even if having an implementation similar to VSCode it would still be needed to create proper actions for things like creating adding a new file, renaming or moving, otherwise people may still forget to do this (and I guess it works like that in there?).

By the way, I forgot to comment that actually the rename operations are not properly handled... they are just creating an "Add" for the new file with the new name :/. I will create another ticket.

[gene-pavlovsky]

I'd like to be able to use only renaming/moving - most useful feature, in my opinion.
So would be nice if there would be a few options in the plugin settings to select the desired features subset.

[gene-pavlovsky]

So how are we going to move forward with this? @Neverbirth