Skip to content

Commit

Permalink
Merge pull request #17186 from kit-ty-kate/rm-test-cycle
Browse files Browse the repository at this point in the history
Mitigate test dependency cycle (ocaml-opam/opam-depext#121) between base, dune-configurator and csexp
  • Loading branch information
fdopen committed Sep 13, 2020
1 parent 1d62d9e commit 6f4f51d
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 12 deletions.
5 changes: 3 additions & 2 deletions packages/csexp/csexp.1.0.0/opam
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ bug-reports: "https://github.com/ocaml-dune/csexp/issues"
depends: [
"dune" {>= "2.0"}
"ocaml" {>= "4.04.0"}
"ppx_expect" {with-test & < "v0.15"}
# "ppx_expect" {with-test & < "v0.15"}
# Disabled because of a dependency cycle (see https://github.com/ocaml-opam/opam-depext/issues/121)
]
build: [
["dune" "subst"] {pinned}
Expand All @@ -42,7 +43,7 @@ build: [
"-j"
jobs
"@install"
"@runtest" {with-test}
# "@runtest" {with-test}
"@doc" {with-doc}
]
]
Expand Down
5 changes: 3 additions & 2 deletions packages/csexp/csexp.1.1.0/opam
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ bug-reports: "https://github.com/ocaml-dune/csexp/issues"
depends: [
"dune" {>= "2.5"}
"ocaml" {>= "4.02.3"}
"ppx_expect" {with-test & < "v0.15"}
# "ppx_expect" {with-test & < "v0.15"}
# Disabled because of a dependency cycle (https://github.com/ocaml-opam/opam-depext/issues/121)
"result" {>= "1.5"}
]
build: [
Expand All @@ -43,7 +44,7 @@ build: [
"-j"
jobs
"@install"
"@runtest" {with-test}
# "@runtest" {with-test}
"@doc" {with-doc}
]
]
Expand Down
5 changes: 3 additions & 2 deletions packages/csexp/csexp.1.2.0/opam
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ bug-reports: "https://github.com/ocaml-dune/csexp/issues"
depends: [
"dune" {>= "2.5"}
"ocaml" {>= "4.02.3"}
"ppx_expect" {with-test}
# "ppx_expect" {with-test}
# Disabled because of a dependency cycle (https://github.com/ocaml-opam/opam-depext/issues/121)
"result" {>= "1.5"}
]
build: [
Expand All @@ -43,7 +44,7 @@ build: [
"-j"
jobs
"@install"
"@runtest" {with-test}
# "@runtest" {with-test}
"@doc" {with-doc}
]
]
Expand Down
5 changes: 3 additions & 2 deletions packages/csexp/csexp.1.2.2/opam
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ bug-reports: "https://github.com/ocaml-dune/csexp/issues"
depends: [
"dune" {>= "2.5"}
"ocaml" {>= "4.02.3"}
"ppx_expect" {with-test}
# "ppx_expect" {with-test}
# Disabled because of a dependency cycle (see https://github.com/ocaml-opam/opam-depext/issues/121)
"result" {>= "1.5"}
]
build: [
Expand All @@ -43,7 +44,7 @@ build: [
"-j"
jobs
"@install"
"@runtest" {with-test}
# "@runtest" {with-test}
"@doc" {with-doc}
]
]
Expand Down
5 changes: 3 additions & 2 deletions packages/csexp/csexp.1.2.3/opam
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ bug-reports: "https://github.com/ocaml-dune/csexp/issues"
depends: [
"dune" {>= "2.5"}
"ocaml" {>= "4.02.3"}
"ppx_expect" {with-test}
# "ppx_expect" {with-test}
# Disabled because of a dependency cycle (see https://github.com/ocaml-opam/opam-depext/issues/121)
"result" {>= "1.5"}
]
build: [
Expand All @@ -43,7 +44,7 @@ build: [
"-j"
jobs
"@install"
"@runtest" {with-test}
# "@runtest" {with-test}
"@doc" {with-doc}
]
]
Expand Down
5 changes: 3 additions & 2 deletions packages/csexp/csexp.1.3.1/opam
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ bug-reports: "https://github.com/ocaml-dune/csexp/issues"
depends: [
"dune" {>= "2.5"}
"ocaml" {>= "4.02.3"}
"ppx_expect" {with-test}
# "ppx_expect" {with-test}
# Disabled because of a dependency cycle (see https://github.com/ocaml-opam/opam-depext/issues/121)
"result" {>= "1.5"}
]
build: [
Expand All @@ -43,7 +44,7 @@ build: [
"-j"
jobs
"@install"
"@runtest" {with-test}
# "@runtest" {with-test}
"@doc" {with-doc}
]
]
Expand Down

0 comments on commit 6f4f51d

Please sign in to comment.