-
Notifications
You must be signed in to change notification settings - Fork 12
Updated Language Service API. #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Updated Language Service to microsoft/TypeScript@6287efc with corresponding API changes. * Removed typescriptServices.js from bin/main.js and bin/worker.js bundles, loading dynamically instead.
|
Anyway I would prefer to work on a special branch, since master should always be installable with install from url feature of brackets |
|
Np, I thought about that after sending PR. Unfortunately, it's not possible to select another branch after sending it, so there are still options of closing+reopening as another one on my side, or, merging manually to |
|
For the moment since you still want to commit something just work on this 2014-08-18 11:23 GMT+02:00 Ingvar Stepanyan notifications@github.com:
|
|
Fixed loading, but there is still some weird bug with autocomplete. Spent few hours looking for reason, but no luck as for now. |
|
@fdecampredon Ah, looks like it's problem in new TypeScript Language Service that doesn't normally handle built-in references i.e. to modules declared with Autocompletion works fine on small test projects with few files that depend on each other, so it's generally possible to start experimenting while waiting for stabilization of new API. |
|
Submitted this issue as microsoft/TypeScript#492. |
…ct`. Could simply use `ts.createSourceFileObject`, but in that case `getSyntaxTree()` won't work since it relies on existing of `scriptSnapshot` property. Could also simply add this property, but decided to go with corresponding ready-to-use factory for better maintainability.
|
@fdecampredon Submitted fix for that issue & merged it here. |
New API is unstable as it's part of new compiler rewrite, but might be useful to start migrating to it as earlier as possible since it breaks compatibility for older code.