Skip to content

Conversation

@RReverser
Copy link

  • Updated Language Service to microsoft/TypeScript@6287efc with corresponding API changes.
  • Removed typescriptServices.js from bin/main.js and bin/worker.js bundles, loading dynamically instead.

New API is unstable as it's part of new compiler rewrite, but might be useful to start migrating to it as earlier as possible since it breaks compatibility for older code.

* Updated Language Service to microsoft/TypeScript@6287efc with corresponding API changes.
* Removed typescriptServices.js from bin/main.js and bin/worker.js bundles, loading dynamically instead.
@fdecampredon
Copy link
Owner

Anyway I would prefer to work on a special branch, since master should always be installable with install from url feature of brackets

@RReverser
Copy link
Author

Np, I thought about that after sending PR. Unfortunately, it's not possible to select another branch after sending it, so there are still options of closing+reopening as another one on my side, or, merging manually to develop branch locally on your side.

@fdecampredon
Copy link
Owner

For the moment since you still want to commit something just work on this
PR, I'll review it after your commit then merge on another branch manually.

2014-08-18 11:23 GMT+02:00 Ingvar Stepanyan notifications@github.com:

Np, I thought about that after sending PR. Unfortunately, it's not
possible to select another branch after sending it, so there are still
options of closing+reopening as another one on my side, or, merging
manually to develop branch locally on your side.


Reply to this email directly or view it on GitHub
#31 (comment)
.

@RReverser
Copy link
Author

Fixed loading, but there is still some weird bug with autocomplete. Spent few hours looking for reason, but no luck as for now.

@RReverser
Copy link
Author

@fdecampredon Ah, looks like it's problem in new TypeScript Language Service that doesn't normally handle built-in references i.e. to modules declared with declare module ... and so fails in assertion createCompilerHost().getSourceFile(filename) since reference is actually not a filename.

Autocompletion works fine on small test projects with few files that depend on each other, so it's generally possible to start experimenting while waiting for stabilization of new API.

@RReverser
Copy link
Author

Submitted this issue as microsoft/TypeScript#492.

…ct`.

Could simply use `ts.createSourceFileObject`, but in that case `getSyntaxTree()`
won't work since it relies on existing of `scriptSnapshot` property.

Could also simply add this property, but decided to go with corresponding
ready-to-use factory for better maintainability.
@RReverser
Copy link
Author

@fdecampredon Submitted fix for that issue & merged it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants