Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deflate): Non working deflate transfer mode #461

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(deflate): Non working deflate transfer mode #461

wants to merge 5 commits into from

Conversation

fclairamb
Copy link
Owner

No description provided.

@fclairamb
Copy link
Owner Author

fclairamb commented Jun 2, 2024 •
edited
Loading

Ok so I now understand where it's coming from but it requires some design changes. I have created a deflateConn struct that is designed to be used as a net.Conn but the original net.Conn reference is kept in the passive/active transfer handlers.

Which makes us not flush the data at the end of the transfer. This is why download doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fclairamb