Skip to content

Commit

Permalink
Revert "DEV: upgrade to Rails 6.0.3"
Browse files Browse the repository at this point in the history
This was causing issues during multisite:migrate

https://meta.discourse.org/t/multisite-migrate-broken-since-rails-6-0-3-update/150691

This reverts commit 136a545.
  • Loading branch information
davidtaylorhq committed May 7, 2020
1 parent 87b1d43 commit 2ff8b4f
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 42 deletions.
14 changes: 7 additions & 7 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ else
# this allows us to include the bits of rails we use without pieces we do not.
#
# To issue a rails update bump the version number here
gem 'actionmailer', '6.0.3'
gem 'actionpack', '6.0.3'
gem 'actionview', '6.0.3'
gem 'activemodel', '6.0.3'
gem 'activerecord', '6.0.3'
gem 'activesupport', '6.0.3'
gem 'railties', '6.0.3'
gem 'actionmailer', '6.0.2.2'
gem 'actionpack', '6.0.2.2'
gem 'actionview', '6.0.2.2'
gem 'activemodel', '6.0.2.2'
gem 'activerecord', '6.0.2.2'
gem 'activesupport', '6.0.2.2'
gem 'railties', '6.0.2.2'
gem 'sprockets-rails'
end

Expand Down
58 changes: 29 additions & 29 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
GEM
remote: https://rubygems.org/
specs:
actionmailer (6.0.3)
actionpack (= 6.0.3)
actionview (= 6.0.3)
activejob (= 6.0.3)
actionmailer (6.0.2.2)
actionpack (= 6.0.2.2)
actionview (= 6.0.2.2)
activejob (= 6.0.2.2)
mail (~> 2.5, >= 2.5.4)
rails-dom-testing (~> 2.0)
actionpack (6.0.3)
actionview (= 6.0.3)
activesupport (= 6.0.3)
actionpack (6.0.2.2)
actionview (= 6.0.2.2)
activesupport (= 6.0.2.2)
rack (~> 2.0, >= 2.0.8)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.0)
rails-html-sanitizer (~> 1.0, >= 1.2.0)
actionview (6.0.3)
activesupport (= 6.0.3)
actionview (6.0.2.2)
activesupport (= 6.0.2.2)
builder (~> 3.1)
erubi (~> 1.4)
rails-dom-testing (~> 2.0)
Expand All @@ -24,20 +24,20 @@ GEM
actionview (>= 6.0.a)
active_model_serializers (0.8.4)
activemodel (>= 3.0)
activejob (6.0.3)
activesupport (= 6.0.3)
activejob (6.0.2.2)
activesupport (= 6.0.2.2)
globalid (>= 0.3.6)
activemodel (6.0.3)
activesupport (= 6.0.3)
activerecord (6.0.3)
activemodel (= 6.0.3)
activesupport (= 6.0.3)
activesupport (6.0.3)
activemodel (6.0.2.2)
activesupport (= 6.0.2.2)
activerecord (6.0.2.2)
activemodel (= 6.0.2.2)
activesupport (= 6.0.2.2)
activesupport (6.0.2.2)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
zeitwerk (~> 2.2)
addressable (2.7.0)
public_suffix (>= 2.0.2, < 5.0)
annotate (3.1.1)
Expand Down Expand Up @@ -184,7 +184,7 @@ GEM
mini_mime (>= 0.1.1)
maxminddb (0.1.22)
memory_profiler (0.9.14)
message_bus (3.2.0)
message_bus (3.1.0)
rack (>= 1.1.3)
method_source (1.0.0)
mini_mime (1.0.2)
Expand Down Expand Up @@ -281,9 +281,9 @@ GEM
rails_multisite (2.1.1)
activerecord (> 5.0, < 7)
railties (> 5.0, < 7)
railties (6.0.3)
actionpack (= 6.0.3)
activesupport (= 6.0.3)
railties (6.0.2.2)
actionpack (= 6.0.2.2)
activesupport (= 6.0.2.2)
method_source
rake (>= 0.8.7)
thor (>= 0.20.3, < 2.0)
Expand Down Expand Up @@ -428,14 +428,14 @@ PLATFORMS
ruby

DEPENDENCIES
actionmailer (= 6.0.3)
actionpack (= 6.0.3)
actionview (= 6.0.3)
actionmailer (= 6.0.2.2)
actionpack (= 6.0.2.2)
actionview (= 6.0.2.2)
actionview_precompiler
active_model_serializers (~> 0.8.3)
activemodel (= 6.0.3)
activerecord (= 6.0.3)
activesupport (= 6.0.3)
activemodel (= 6.0.2.2)
activerecord (= 6.0.2.2)
activesupport (= 6.0.2.2)
addressable
annotate
aws-sdk-s3
Expand Down Expand Up @@ -512,7 +512,7 @@ DEPENDENCIES
rack-mini-profiler
rack-protection
rails_multisite
railties (= 6.0.3)
railties (= 6.0.2.2)
rake
rb-fsevent
rb-inotify (~> 0.9)
Expand Down
5 changes: 0 additions & 5 deletions config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,6 @@ def config.database_configuration
end
end

# we skip it cause we configure it in the initializer
# the railstie for message_bus would insert it in the
# wrong position
config.skip_message_bus_middleware = true

# Disable so this is only run manually
# we may want to change this later on
# issue is image_optim crashes on missing dependencies
Expand Down
6 changes: 5 additions & 1 deletion config/initializers/200-first_middlewares.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@
#
# We aren't manipulating the middleware stack directly because of
# https://github.com/rails/rails/pull/27936
session_operations = Rails::Configuration::MiddlewareStackProxy.new([
[:delete, MessageBus::Rack::Middleware],
[:unshift, MessageBus::Rack::Middleware],
])

Rails.configuration.middleware.unshift(MessageBus::Rack::Middleware)
Rails.configuration.middleware = Rails.configuration.middleware + session_operations

# no reason to track this in development, that is 300+ redis calls saved per
# page view (we serve all assets out of thin in development)
Expand Down

0 comments on commit 2ff8b4f

Please sign in to comment.