feat(windows): add native msvc build support for generals base game - #262
Merged
Conversation
- Backport Win32 CMake and CompatLib configurations from Zero Hour to Generals base game - Use shared Core/GameEngineDevice Win32 sources for g_gameenginedevice - Enable matrix build in build-windows.yml for both GeneralsMD and Generals - Trigger Windows builds when base game changes are detected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores native MSVC Windows x86 build support for the Generals base game (
Generals/), backporting the configurations from Zero Hour (GeneralsMD/).Changes
Generals/Code/GameEngineDevice/CMakeLists.txtto sharedCore/GameEngineDevice/Source/Win32Device/implementations (Win32GameEngine.cpp,Win32OSDisplay.cpp,Win32DIKeyboard.cpp,Win32Mouse.cpp).d3d8liblinkage andif(UNIX)CompatLib guard toGenerals/Code/GameEngine/CMakeLists.txtandGenerals/Code/CMakeLists.txt.comip.h,comutil.h,windows.h) fromGenerals/Code/CompatLib/Include/.windows_wrapper.hto include SDK<windows.h>under Windows and syncD3DXMATRIXconstructors ind3dx8math.h..github/workflows/build-windows.ymlto a matrix building bothgeneralsxzh(GeneralsXZH.exe) andgeneralsx(GeneralsX.exe).ci.ymlto triggerbuild-windowswhen either Zero Hour or Generals base game changes are detected.Validation
feature/windows-generals-base-x86.