feat: dynamic project watermark and update checker fixes - #249
Merged
Conversation
Extract git tag prefix and capitalize for semantic versioning in main menu watermark.
Instrument the update checker to diagnose missing tag issues during GitHub Actions builds.
Add checkout_ref input to reusable build workflows and pass the tag ref from release workflow to ensure actions/checkout fetches the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a dynamic project watermark in the main menu based on the Git tag (with Semantic Versioning fallback). It also instruments the
UpdateCheckerwith extensive logs to diagnose issues with GitHub releases, and fixes a CI bug whereactions/checkoutwas not fetching the newly created tag by passing an explicitcheckout_ref.Changes
TheVersion->getUnicodeProjectWatermark()which replaces the hardcoded string with the Git tag, stripping thegeneralsx-prefix and capitalizing the first letter.fprintf(stderr)instrumentation at various stages to diagnose missing tags or incorrect timestamps during update checks.checkout_refinput tobuild-macos.ymlandbuild-linux-flatpak.yml, and updatedrelease.ymlto pass the newly created tag reference explicitly.