Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower bound to version check, fixes #51, #52 #55

Merged
merged 1 commit into from
Apr 12, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add lower bound to version check, fixes #51, #52
  • Loading branch information
dvenza committed Dec 11, 2022
commit 5df4df176382438476b2edadb3ac5f0dfbe93719
2 changes: 1 addition & 1 deletion openwrt_luci_rpc/utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ def get_hostname_from_dhcp(dhcp_result, mac):
def is_legacy_version(owrt_version):
return (
"snapshot" not in owrt_version.public and
owrt_version < version.parse("18.06")
version.parse("18.06") > owrt_version >= version.parse("15.06")
)