Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indicator for years with 0 values #833

Merged
merged 3 commits into from
Jun 7, 2017
Merged

Conversation

jeremiak
Copy link
Contributor

@jeremiak jeremiak commented Jun 5, 2017

Closes #818

@jeremiak jeremiak force-pushed the jk-no-data-marker branch from fa81287 to a70bad1 Compare June 7, 2017 01:16
@jeremiak jeremiak changed the title [WIP] Add indicator for years with 0 values Add indicator for years with 0 values Jun 7, 2017
@@ -56,6 +56,10 @@ class AgencyChart extends React.Component {

const y = scaleLinear().domain([0, yMax]).rangeRound([height, 0]).nice()

const x = scaleTime()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this const x needed? i don't see it used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, will remove

@brendansudol brendansudol merged commit 28600aa into master Jun 7, 2017
@brendansudol brendansudol deleted the jk-no-data-marker branch June 7, 2017 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants