Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show percents by default in <NibrsTable /> #632

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

jeremiak
Copy link
Contributor

@amberwreed Defaulting to percents still has a sentence with the total counts that don't add up.

Default to counts:
screen shot 2017-03-23 at 6 08 03 pm

Default to percents:
screen shot 2017-03-23 at 6 07 43 pm

Refs #631

@amberwreed
Copy link

amberwreed commented Mar 23, 2017 via email

@jeremiak
Copy link
Contributor Author

jeremiak commented Mar 30, 2017

@amberwreed I don't really. I would say that showing the disparate totals have value and maybe this is something that we need to explain with text like "Why are these numbers different?".

@brendansudol
Copy link
Contributor

🚢 , and we can keep refining down the road if need be

@brendansudol brendansudol merged commit 363e251 into master Apr 6, 2017
@brendansudol brendansudol deleted the jk-default-to-perct branch April 6, 2017 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants