Private API overview #405
Merged
Private API overview #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code from
client.py->_client.py,models.py->_models.pyandgraphql.py->_graphql.py. This is done so that we have an overview of the public API, and can take steps to gradually limit it.This PR looks really huge on first sight, but that's because
git-diffdoesn't like creating a file with the same name as a moved file. If you look at each commit separately, the changes are really simple!I haven't considered
imports as part of the public API, if someone relied on those, their code would break! But I think this privatization is gonna be an iterative process, and personally, I'd much rather have to fix an import, than redo my entire codebase, just because the library got updated.