Skip to content

Replace lxml with Python's built in html.parser #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madsmtm merged 4 commits into from
Jun 20, 2018
Merged

Replace lxml with Python's built in html.parser #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2ff7fe
Replace lxml with Python's built in html.parser
orenyomtov Jun 14, 2018
73f4c98
Remove lxml dependency
orenyomtov Jun 14, 2018
6673651
Remove lxml dependency
orenyomtov Jun 14, 2018
843c0f6
Merge branch 'master' into patch-4
madsmtm Jun 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fbchat/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def _postLogin(self):
self.ttstamp = ''

r = self._get(self.req_url.BASE)
soup = bs(r.text, "lxml")
soup = bs(r.text, "html.parser")

fb_dtsg_element = soup.find("input", {'name': 'fb_dtsg'})
if fb_dtsg_element:
Expand Down Expand Up @@ -252,7 +252,7 @@ def _login(self):
if not (self.email and self.password):
raise FBchatUserError("Email and password not found.")

soup = bs(self._get(self.req_url.MOBILE).text, "lxml")
soup = bs(self._get(self.req_url.MOBILE).text, "html.parser")
data = dict((elem['name'], elem['value']) for elem in soup.findAll("input") if elem.has_attr('value') and elem.has_attr('name'))
data['email'] = self.email
data['pass'] = self.password
Expand All @@ -277,7 +277,7 @@ def _login(self):
return False, r.url

def _2FA(self, r):
soup = bs(r.text, "lxml")
soup = bs(r.text, "html.parser")
data = dict()

s = self.on2FACode()
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
requests
lxml
beautifulsoup4
enum34; python_version < '3.4'
1 change: 0 additions & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ packages = find:
python_requires = >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, <4.0
install_requires =
requests
lxml
beautifulsoup4
# May not work in pip with bdist_wheel
# See https://wheel.readthedocs.io/en/latest/#defining-conditional-dependencies
Expand Down