Skip to content

Fix CONTENT_TYPE and CONTENT_LENGTH handling #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2016
Merged

Conversation

fbbdev
Copy link
Owner

@fbbdev fbbdev commented Sep 29, 2016

Fix #15

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 65.974% when pulling 71be407 on content-length-type into b4612a5 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 65.974% when pulling 71be407 on content-length-type into b4612a5 on master.

@coveralls
Copy link

coveralls commented Sep 29, 2016

Coverage Status

Coverage increased (+0.2%) to 65.974% when pulling 71be407 on content-length-type into b4612a5 on master.

@fbbdev fbbdev merged commit ab1991a into master Sep 29, 2016
@fbbdev fbbdev deleted the content-length-type branch September 29, 2016 07:59
@robertgroh
Copy link
Contributor

@fbbdev:
Thank you very much for your work.
This fixed bug (#15) could be a explanation for some strange behaivor, which I always suspected to be the result our buggy code at work.

It is nice to see, that you document such bugs as own issues and add a test for the fix.
I hope more developers would also do the same.

Your work is very appreciated.

@fbbdev
Copy link
Owner Author

fbbdev commented Sep 29, 2016

@robertgroh:
Now this made me blush 😊. I have to thank you in turn, because with your pull request you taught me to write tests and how to write them, and this is being beneficial to other projects I'm working on. It also enhanced my development workflow in many ways and made it much more comfortable.

Please report an issue if you see that buggy behavior again, I'd be happy to investigate. #15 was introduced in the 1.1.0 rewrite. Previous versions should not be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants