Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the project from an older ESLint configuration to a shared @feedic/eslint-config, adds Biome for formatting and linting, and upgrades ESLint from v8 to v10. The PR applies automated fixes for various linting rules including variable naming conventions, import style changes, and code simplifications.
Changes:
- Replaced
.eslintrc.jsonwith flat configeslint.config.mjsusing shared@feedic/eslint-config - Added Biome for formatting (replacing Prettier) with configuration in
biome.json - Updated dependencies: ESLint v8→v10, removed Prettier, added typescript-eslint v8.56.0, added Biome v2.4.4
- Applied auto-fixes: renamed variables (prev→previous, i→index, el→element, err→error), changed imports to node: prefix, replaced Object.prototype.hasOwnProperty with Object.hasOwn, converted forEach to for-of loops
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| eslint.config.mjs | New flat ESLint configuration using shared config with TypeScript support |
| biome.json | New Biome configuration for formatting and linting |
| .eslintrc.json | Removed old ESLint configuration file |
| package.json | Updated dependencies, reordered exports, reorganized scripts, added "type": "commonjs" |
| package-lock.json | Lockfile updates for new dependencies |
| src/node.ts | Variable renaming, Object.hasOwn usage, forEach→for-of conversions |
| src/node.spec.ts | Variable renaming, import type annotations, Number.NaN usage |
| src/index.ts | Import reordering with type imports, variable renaming |
| src/index.spec.ts | Node: prefix for built-in imports, forEach→for loop conversion, variable renaming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.