Skip to content

chore(lint): Use shared eslint config#1844

Open
fb55 wants to merge 3 commits intomasterfrom
shared-config
Open

chore(lint): Use shared eslint config#1844
fb55 wants to merge 3 commits intomasterfrom
shared-config

Conversation

@fb55
Copy link
Owner

@fb55 fb55 commented Feb 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 21, 2026 23:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the project from an older ESLint configuration to a shared @feedic/eslint-config, adds Biome for formatting and linting, and upgrades ESLint from v8 to v10. The PR applies automated fixes for various linting rules including variable naming conventions, import style changes, and code simplifications.

Changes:

  • Replaced .eslintrc.json with flat config eslint.config.mjs using shared @feedic/eslint-config
  • Added Biome for formatting (replacing Prettier) with configuration in biome.json
  • Updated dependencies: ESLint v8→v10, removed Prettier, added typescript-eslint v8.56.0, added Biome v2.4.4
  • Applied auto-fixes: renamed variables (prev→previous, i→index, el→element, err→error), changed imports to node: prefix, replaced Object.prototype.hasOwnProperty with Object.hasOwn, converted forEach to for-of loops

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
eslint.config.mjs New flat ESLint configuration using shared config with TypeScript support
biome.json New Biome configuration for formatting and linting
.eslintrc.json Removed old ESLint configuration file
package.json Updated dependencies, reordered exports, reorganized scripts, added "type": "commonjs"
package-lock.json Lockfile updates for new dependencies
src/node.ts Variable renaming, Object.hasOwn usage, forEach→for-of conversions
src/node.spec.ts Variable renaming, import type annotations, Number.NaN usage
src/index.ts Import reordering with type imports, variable renaming
src/index.spec.ts Node: prefix for built-in imports, forEach→for loop conversion, variable renaming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants