-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force add schema from template to rule target group #65
Force add schema from template to rule target group #65
Conversation
@favoyang If you have time, please take a look at this. Thanks |
I'm a little bit surprised at how
Then I think forceAddSchemaFromTemplate is not an option. Just remove the boolean and let it run every time before
This is another feature, let's just leave it there. |
Sorry for the very late reply. (I didn't get notification from this, or maybe I missed the mail). |
…asset_from_template_group
…ma before apply template to group
@favoyang I know this was an very old PR but it still needed feature (I think so I update the code as the advice you gave me) so if you have time please take a look. Will take an eye on this repo more and see if I can contribute more. |
I will review it later this week. Thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
# [0.15.0](v0.14.1...v0.15.0) (2022-12-25) ### Features * force add schema from template to rule target group ([#65](#65)) ([d553499](d553499))
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I've created a group template:
And all I wanna do is my rule target group will be create from this template but the code not work as I expected and always give me this warning, the new created group not have the schema of my group, it only have the BundledAssetGroupSchema. After deep dive into code I think this feature is must have so I create this RP, if you have time, please take a look at this.
I also think of force remove schema if template don't have that, but I'm not sure if it need so I just leave it there