Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warnings for missing AddressableImportSettingsasset #15

Closed
EgilSandfeld opened this issue Jan 30, 2020 · 2 comments
Closed

No warnings for missing AddressableImportSettingsasset #15

EgilSandfeld opened this issue Jan 30, 2020 · 2 comments
Assignees

Comments

@EgilSandfeld
Copy link

EgilSandfeld commented Jan 30, 2020

Checking out this plugin and found an issue when I created the AddressableImportSettings asset using the Usage docs. It gave me no errors or warnings, but the following code returned me:

var importSettings = AddressableImportSettings.Instance; if (importSettings == null || importSettings.rules == null || importSettings.rules.Count == 0) return;

I figured to move the AddressableImportSettings asset to Assets/AddressableAssetsData and it worked.

Perhaps a warning or allowing the asset to be placed elsewhere would be great :)

@EgilSandfeld EgilSandfeld changed the title No warnings for missing AddressableImportSettings asset No warnings for missing AddressableImportSettingsasset Jan 30, 2020
@favoyang
Copy link
Owner

Personally I prefer convention over configuration, so I would like to keep the settings file under Assets/AddressableAssetsData. But a warning is helpful indeed.

@favoyang favoyang self-assigned this Jan 31, 2020
github-actions bot pushed a commit that referenced this issue Feb 2, 2020
## [0.5.1](v0.5.0...v0.5.1) (2020-02-02)

### Bug Fixes

* no warnings for missing AddressableImportSettings [#15](#15) ([30dd56a](30dd56a))
github-actions bot pushed a commit that referenced this issue Feb 2, 2020
## [0.5.1](v0.5.0...v0.5.1) (2020-02-02)

### Bug Fixes

* bump semantic-release to v2.1.3 to solve dependencies issue ([c59b986](c59b986))
* no warnings for missing AddressableImportSettings [#15](#15) ([30dd56a](30dd56a))
@favoyang
Copy link
Owner

favoyang commented Feb 2, 2020

Fixed in 30dd56a (v0.5.1)

@favoyang favoyang closed this as completed Feb 2, 2020
github-actions bot pushed a commit to K-Dark/unity-addressable-importer that referenced this issue Feb 20, 2020
# [0.4.0](v0.3.1...v0.4.0) (2020-02-20)

### Bug Fixes

* bump semantic-release to v2.1.3 to solve dependencies issue ([c59b986](c59b986))
* context menu path to create settings ([ea7b90a](ea7b90a))
* no warnings for missing AddressableImportSettings [favoyang#15](https://github.com/K-Dark/unity-addressable-importer/issues/15) ([30dd56a](30dd56a))

### Features

* deploy semantic-release ([d1c4c1b](d1c4c1b))
github-actions bot pushed a commit that referenced this issue Feb 27, 2020
## [0.5.1](v0.5.0...v0.5.1) (2020-02-27)

### Bug Fixes

* bump semantic-release to v2.1.3 to solve dependencies issue ([c59b986](c59b986))
* no warnings for missing AddressableImportSettings [#15](#15) ([30dd56a](30dd56a))
github-actions bot pushed a commit that referenced this issue Feb 27, 2020
## [0.5.1](v0.5.0...v0.5.1) (2020-02-27)

### Bug Fixes

* bump semantic-release to v2.1.3 to solve dependencies issue ([c59b986](c59b986))
* exclude MacOS .DS_Store file ([332a769](332a769))
* no warnings for missing AddressableImportSettings [#15](#15) ([30dd56a](30dd56a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants