Ack filtered messages when using .take() #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-ilin
force-pushed
the
fix_ack_filtered_messages
branch
from
f1f342c to
c99053f
Compare
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 102 102
Lines 11137 11137
Branches 1530 1530
=======================================
Hits 10435 10435
Misses 615 615
Partials 87 87
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
This is awesome, thank you so much for the PR! |
wbarnha
reviewed
Apr 1, 2023
wbarnha
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue:
When using filter().take() chain, the filtered out messages are not getting acked (if
NO_CYTHON=False).There has been a PR #208 which aimed to fix the same issue, but it only fixed it for installations that don't use
cython. ForNO_CYTHON=Falsethis solution didn't work.Solution:
Compare the message value to the
skipped_valueand ack it.Note:
The test I added runs red before fix and green after fix. It may look a little bit clumsy but it shows the issue.
Any suggestions are welcome.