Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 419 #420

Merged
merged 7 commits into from
Jan 4, 2023
Merged

fix for issue 419 #420

merged 7 commits into from
Jan 4, 2023

Conversation

patkivikram
Copy link
Collaborator

@patkivikram patkivikram commented Dec 6, 2022

Description

Possible fix for #419

Please describe your pull request.

NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.

If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #4412) for example.

Copy link
Member

@wbarnha wbarnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't this is the place we need to make changes, we should try looking at this?

await asyncio.wait(
[
dest_chan.put(dest_event)
for dest_event, dest_chan in full
],
return_when=asyncio.ALL_COMPLETED,
)

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 93.86% // Head: 93.86% // No change to project coverage 👍

Coverage data is based on head (085b548) compared to base (a48a7c4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         102      102           
  Lines       11088    11088           
  Branches     1517     1517           
=======================================
  Hits        10408    10408           
  Misses        596      596           
  Partials       84       84           
Impacted Files Coverage Δ
faust/transport/conductor.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wbarnha wbarnha merged commit 89b82ab into master Jan 4, 2023
@wbarnha wbarnha deleted the fix_419 branch January 4, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants