-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for issue 419 #420
fix for issue 419 #420
Conversation
This reverts commit e68821e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't this is the place we need to make changes, we should try looking at this?
faust/faust/transport/conductor.py
Lines 169 to 175 in ebc7777
await asyncio.wait( | |
[ | |
dest_chan.put(dest_event) | |
for dest_event, dest_chan in full | |
], | |
return_when=asyncio.ALL_COMPLETED, | |
) |
Codecov ReportBase: 93.86% // Head: 93.86% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 102 102
Lines 11088 11088
Branches 1517 1517
=======================================
Hits 10408 10408
Misses 596 596
Partials 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
Possible fix for #419
Please describe your pull request.
NOTE: All patches should be made against master, not a maintenance branch like
3.1, 2.5, etc. That is unless the bug is already fixed in master, but not in
that version series.
If it fixes a bug or resolves a feature request,
be sure to link to that issue via (Fixes #4412) for example.