Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_event_loop_policy() to all get_event_loop() calls #415

Merged
merged 59 commits into from
Nov 29, 2022

Conversation

wbarnha
Copy link
Member

@wbarnha wbarnha commented Nov 22, 2022

Start using loop = asyncio.get_event_loop_policy().get_event_loop() since it may be safer as indicated by https://bugs.python.org/issue39529.

Plus we're using it in mode-streaming, so let's be consistent.

TO REVIEW AFTER MERGING #366.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Base: 93.97% // Head: 93.88% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (97624d4) compared to base (7bef2a2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   93.97%   93.88%   -0.10%     
==========================================
  Files         102      102              
  Lines       11085    11085              
  Branches     1302     1516     +214     
==========================================
- Hits        10417    10407      -10     
- Misses        586      595       +9     
- Partials       82       83       +1     
Impacted Files Coverage Δ
faust/streams.py 88.01% <ø> (ø)
faust/worker.py 95.38% <ø> (ø)
faust/cli/base.py 98.20% <100.00%> (ø)
faust/transport/base.py 100.00% <100.00%> (ø)
faust/transport/consumer.py 92.30% <100.00%> (-1.71%) ⬇️
faust/transport/drivers/aiokafka.py 73.49% <100.00%> (ø)
faust/transport/producer.py 89.16% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wbarnha wbarnha marked this pull request as ready for review November 29, 2022 15:48
@wbarnha wbarnha merged commit 7c7fa84 into faust-streaming:master Nov 29, 2022
@wbarnha wbarnha deleted the event_loop_policy branch November 30, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants