Fix: Producer hangs on send pending check with thread producer enabled #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrand
force-pushed
the
fix/timeout-in-flush-almost
branch
from
07a247d to
2f29dcb
Compare
patkivikram
approved these changes
Feb 23, 2022
cbrand
force-pushed
the
fix/timeout-in-flush-almost
branch
from
9745c7c to
23a493e
Compare
|
@patkivikram hopefully fixed the formatting issues (i only ran black on the faust repository and not the tests repository accidentally). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I discovered during implementation on top of faust that on high volume event consumptions that the whole process pipeline suddenly stopped doing anything. No further kafka messages were processed.
After checking the logic i realized that I enabled
PRODUCER_THREADEDand that the thread producer is not thread safe when waiting for new messages to come in.This is fixed in this PR to avoid waiting forever for an event to be set in
flush_atmost.Instead it times out and returns the up until now identified amount of sent messages.
A unit test is added to verify the behavior of this change.