Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record generation_id after fetch #235

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

ekerstens
Copy link
Contributor

Description

Limiting the comparison of generation_id to after the fetcher returns limits the scope of the check to a change of generation_id within getmany itself, leaving it up to the fetcher itself to avoid returning records after a rebalance. This avoids an issue where a rebalance happens during fetching, fetching waits for the rebalance to finishes to return, but then the fetch is discarded (incorrectly) by getmany.

@codecov-commenter
Copy link

Codecov Report

Merging #235 (eaa6c28) into master (40e477f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files         100      100           
  Lines       10759    10759           
  Branches     1471     1471           
=======================================
  Hits        10149    10149           
  Misses        542      542           
  Partials       68       68           
Impacted Files Coverage Δ
faust/transport/consumer.py 95.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e477f...eaa6c28. Read the comment docs.

@patkivikram patkivikram merged commit 499e338 into faust-streaming:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants