Cancel getmany if generation_id changes #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found one more edge case where events from before a rebalance can leak through.
Consumer.getmany
is designed to break out of the loop during a rebalance. However, if the asyncio loop never returns control togetmany
during the rebalance, it will continue to yield events from before the rebalance, andon_message
assigns the incorrect generation_id` Adding logic to check if the generation_id has changed for more robust handling.