Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix for out of order events (#228)" #232

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

patkivikram
Copy link
Collaborator

Reverting changes for #229

@taybin taybin self-requested a review December 3, 2021 16:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #232 (2a81422) into master (03122ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files         100      100           
  Lines       10749    10754    +5     
  Branches     1470     1470           
=======================================
+ Hits        10142    10147    +5     
  Misses        540      540           
  Partials       67       67           
Impacted Files Coverage Δ
faust/transport/consumer.py 95.79% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03122ca...2a81422. Read the comment docs.

@patkivikram patkivikram merged commit 45015a5 into master Dec 3, 2021
@wbarnha wbarnha deleted the revert_changes branch July 3, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants