Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker default web_host to be None #210

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

ran-ka
Copy link
Contributor

@ran-ka ran-ka commented Oct 31, 2021

Description

This pull request only removes the default web_host value when starting the worker from the CLI. This way, if web_host is not provider in the CLI, the app will use the default web_host which is socket.gethostname() as set in settings.py

Not sure why this was kept this way, maybe it's something that was forgotten when moving the configuration to settings.py

Config order of precendence:

  1. Worker CLI config (--web_host, --web_port)
  2. Apps init config
  3. Default config (settings.py)

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #210 (2aca497) into master (9385c81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files         100      100           
  Lines       10740    10740           
  Branches     1214     1214           
=======================================
  Hits        10139    10139           
  Misses        536      536           
  Partials       65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9385c81...2aca497. Read the comment docs.

@patkivikram patkivikram merged commit 41200e4 into faust-streaming:master Nov 2, 2021
aoberegg added a commit to aoberegg/faust that referenced this pull request Nov 2, 2021
Fix worker default web_host to be None (faust-streaming#210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants