-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support swagger #206
Merged
patkivikram
merged 13 commits into
faust-streaming:master
from
ran-ka:feature/support_swagger
Oct 26, 2021
Merged
Feature/support swagger #206
patkivikram
merged 13 commits into
faust-streaming:master
from
ran-ka:feature/support_swagger
Oct 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 94.46% 94.47%
=======================================
Files 100 100
Lines 10643 10652 +9
Branches 1199 1202 +3
=======================================
+ Hits 10054 10063 +9
Misses 524 524
Partials 65 65
Continue to review full report at Codecov.
|
patkivikram
approved these changes
Oct 25, 2021
@ran-ka this should work with any endpoint extending View correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix support for Swagger UI
Goal
Use Swagger and interact with Faust APIs
Bugs
There were two issues that prevented the existing code from working with Swagger
Solution
Demo
I added the swagger docs to the existing internal Faust endpoint
Testing
Tested with library: aiohttp_swagger
Issues
HEAD endpoint: appears in Swagger, I can remove it, but didn't want to break the existing code
aiohttp-swagger3: Has a different interface, so for now I decided not to support it, but if this is of interest to someone, happy to have a chat