Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #197 #198

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fixes #197 #198

merged 1 commit into from
Oct 21, 2021

Conversation

dparker18
Copy link
Contributor

Description

Fixes #197

start_client was getting stuck on calling await self.topics.wait_for_subscriptions(). In client only mode would there ever be valid subscriptions? If not, the changed line could be removed entirely

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #198 (a7cbf54) into master (835f37e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         100      100           
  Lines       10631    10631           
  Branches     1202     1202           
=======================================
  Hits        10048    10048           
  Misses        514      514           
  Partials       69       69           
Impacted Files Coverage Δ
faust/app/base.py 99.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835f37e...a7cbf54. Read the comment docs.

@taybin taybin merged commit 3959268 into faust-streaming:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.start_client() never returns
4 participants