-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually acknowledge take #192
Conversation
I need to take a closer look at this, but a public facing API like this definitely needs one or more unittests. |
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 94.51% 94.04% -0.47%
==========================================
Files 100 100
Lines 10631 10685 +54
Branches 1202 1207 +5
==========================================
+ Hits 10048 10049 +1
- Misses 514 567 +53
Partials 69 69
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add unit tests?
Description
The following change adds a version of take which would allow the user to manually control when the batch is acknowledged. This would be useful for certain applications where we would need to reprocess the un acknowledged messages if the batch fails.
We also added a change to the setup prometheus sensors function which would check the name for naming consistencies with prometheus.
Refer to #189